usb: core: Remove duplicated check in usb_hub_create_port_device
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 17 Oct 2023 21:11:53 +0000 (23:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Oct 2023 10:53:55 +0000 (12:53 +0200)
Simplify the code by not calling hub_is_superspeed() twice.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/b1d77cbc-faa3-4d07-94ff-f6ffb85c6964@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/port.c

index 149bedb8e64ffa8aa44fe3fcd1aff1341c563406..c628c1abc90711cb9b8e652a0d903a6359c968bc 100644 (file)
@@ -713,6 +713,7 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1)
        set_bit(port1, hub->power_bits);
        port_dev->dev.parent = hub->intfdev;
        if (hub_is_superspeed(hdev)) {
+               port_dev->is_superspeed = 1;
                port_dev->usb3_lpm_u1_permit = 1;
                port_dev->usb3_lpm_u2_permit = 1;
                port_dev->dev.groups = port_dev_usb3_group;
@@ -720,8 +721,6 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1)
                port_dev->dev.groups = port_dev_group;
        port_dev->dev.type = &usb_port_device_type;
        port_dev->dev.driver = &usb_port_driver;
-       if (hub_is_superspeed(hub->hdev))
-               port_dev->is_superspeed = 1;
        dev_set_name(&port_dev->dev, "%s-port%d", dev_name(&hub->hdev->dev),
                        port1);
        mutex_init(&port_dev->status_lock);