fpga: fpga-mgr: altera-ps-spi: Simplify registration
authorMoritz Fischer <mdf@kernel.org>
Sun, 15 Nov 2020 19:51:19 +0000 (11:51 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Dec 2020 17:49:32 +0000 (18:49 +0100)
Simplify registration by using new devm_fpga_mgr_register() API.

Reviewed-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Link: https://lore.kernel.org/r/20201115195127.284487-3-mdf@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/altera-ps-spi.c

index 0221dee8dd4c6b3e90f159ec024f09e4ee847390..23bfd4d1ad0f742b44c399894147ed825345e23a 100644 (file)
@@ -307,18 +307,7 @@ static int altera_ps_probe(struct spi_device *spi)
        if (!mgr)
                return -ENOMEM;
 
-       spi_set_drvdata(spi, mgr);
-
-       return fpga_mgr_register(mgr);
-}
-
-static int altera_ps_remove(struct spi_device *spi)
-{
-       struct fpga_manager *mgr = spi_get_drvdata(spi);
-
-       fpga_mgr_unregister(mgr);
-
-       return 0;
+       return devm_fpga_mgr_register(&spi->dev, mgr);
 }
 
 static const struct spi_device_id altera_ps_spi_ids[] = {
@@ -337,7 +326,6 @@ static struct spi_driver altera_ps_driver = {
        },
        .id_table = altera_ps_spi_ids,
        .probe = altera_ps_probe,
-       .remove = altera_ps_remove,
 };
 
 module_spi_driver(altera_ps_driver)