drivers: base: Print a warning instead of panic() when register_cpu() fails
authorJames Morse <james.morse@arm.com>
Tue, 21 Nov 2023 13:44:46 +0000 (13:44 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Dec 2023 03:41:49 +0000 (12:41 +0900)
loongarch, mips, parisc, riscv and sh all print a warning if
register_cpu() returns an error. Architectures that use
GENERIC_CPU_DEVICES call panic() instead.

Errors in this path indicate something is wrong with the firmware
description of the platform, but the kernel is able to keep running.

Downgrade this to a warning to make it easier to debug this issue.

This will allow architectures that switching over to GENERIC_CPU_DEVICES
to drop their warning, but keep the existing behaviour.

Signed-off-by: James Morse <james.morse@arm.com>
Reviewed-by: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Reviewed-by: Shaoqin Huang <shahuang@redhat.com>
Signed-off-by: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/E1r5R3W-00CszU-GM@rmk-PC.armlinux.org.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/cpu.c

index 221ffbeb1c9becd9a84cb24a0144560f0debb444..82b6a76125f5ee2c7f731a2606cc781bbc82ddaa 100644 (file)
@@ -551,14 +551,15 @@ void __weak arch_unregister_cpu(int num)
 
 static void __init cpu_dev_register_generic(void)
 {
-       int i;
+       int i, ret;
 
        if (!IS_ENABLED(CONFIG_GENERIC_CPU_DEVICES))
                return;
 
        for_each_present_cpu(i) {
-               if (arch_register_cpu(i))
-                       panic("Failed to register CPU device");
+               ret = arch_register_cpu(i);
+               if (ret)
+                       pr_warn("register_cpu %d failed (%d)\n", i, ret);
        }
 }