NFSD: Demote a WARN to a pr_warn()
authorChuck Lever <chuck.lever@oracle.com>
Fri, 8 Jul 2022 18:23:45 +0000 (14:23 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 30 Jul 2022 00:09:21 +0000 (20:09 -0400)
The call trace doesn't add much value, but it sure is noisy.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4proc.c

index d267b9bcf1fc7542dfe8e37348c6a01e8101fe55..5af9f8d1feb6e7d64eafdffd5af88da656c84c77 100644 (file)
@@ -630,9 +630,9 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
        }
 
        status = nfsd4_process_open2(rqstp, resfh, open);
-       WARN(status && open->op_created,
-            "nfsd4_process_open2 failed to open newly-created file! status=%u\n",
-            be32_to_cpu(status));
+       if (status && open->op_created)
+               pr_warn("nfsd4_process_open2 failed to open newly-created file: status=%u\n",
+                       be32_to_cpu(status));
        if (reclaim && !status)
                nn->somebody_reclaimed = true;
 out: