serial: msm_serial: add sparse context annotation
authorJohan Hovold <johan@kernel.org>
Thu, 23 Jul 2020 12:33:27 +0000 (14:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jul 2020 08:44:27 +0000 (10:44 +0200)
Add sparse context annotation to the receive handlers, which release and
reacquire the port lock, to silence sparse warnings:

drivers/tty/serial/msm_serial.c:748:25: warning: context imbalance in 'msm_handle_rx_dm' - unexpected unlock
drivers/tty/serial/msm_serial.c:814:28: warning: context imbalance in 'msm_handle_rx' - unexpected unlock

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200723123327.5843-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/msm_serial.c

index 60a9c53fa7cbf9c03e9277bb5e580596170ea9e6..87f005e5d2affddec960654ebc39efb93c601bcc 100644 (file)
@@ -696,6 +696,7 @@ static void msm_enable_ms(struct uart_port *port)
 }
 
 static void msm_handle_rx_dm(struct uart_port *port, unsigned int misr)
+       __must_hold(&port->lock)
 {
        struct tty_port *tport = &port->state->port;
        unsigned int sr;
@@ -771,6 +772,7 @@ static void msm_handle_rx_dm(struct uart_port *port, unsigned int misr)
 }
 
 static void msm_handle_rx(struct uart_port *port)
+       __must_hold(&port->lock)
 {
        struct tty_port *tport = &port->state->port;
        unsigned int sr;