MIPS: DTS: CI20: fix reset line polarity of the ethernet controller
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 18 Nov 2022 16:43:47 +0000 (08:43 -0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Mon, 21 Nov 2022 16:56:19 +0000 (17:56 +0100)
The reset line is called PWRST#, annotated as "active low" in the
binding documentation, and is driven low and then high by the driver to
reset the chip. However in device tree for CI20 board it was incorrectly
marked as "active high". Fix it.

Because (as far as I know) the ci20.dts is always built in the kernel I
elected not to also add a quirk to gpiolib to force the polarity there.

Fixes: db49ca38579d ("net: davicom: dm9000: switch to using gpiod API")
Reported-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/boot/dts/ingenic/ci20.dts

index 37c46720c719a6fb528fc530a3a93b2d7c527677..f38c39572a9e82f2412fd0b4ee2a7ada7cd69ca3 100644 (file)
                ingenic,nemc-tAW = <50>;
                ingenic,nemc-tSTRV = <100>;
 
-               reset-gpios = <&gpf 12 GPIO_ACTIVE_HIGH>;
+               reset-gpios = <&gpf 12 GPIO_ACTIVE_LOW>;
                vcc-supply = <&eth0_power>;
 
                interrupt-parent = <&gpe>;