fs/proc/task_mmu.c: add_to_pagemap: remove useless parameter addr
authorHui Zhu <teawater@antgroup.com>
Thu, 11 Jan 2024 08:45:33 +0000 (08:45 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 22 Feb 2024 00:00:04 +0000 (16:00 -0800)
Function parameter addr of add_to_pagemap() is useless.  Remove it.

Link: https://lkml.kernel.org/r/20240111084533.40038-1-teawaterz@linux.alibaba.com
Signed-off-by: Hui Zhu <teawater@antgroup.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrei Vagin <avagin@google.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/proc/task_mmu.c

index ac6ea2cc2ee8fee2a5430fdf4e97baa7b917d8d4..23fbab954c20b62b7b67413763ca777001073d3b 100644 (file)
@@ -1352,8 +1352,7 @@ static inline pagemap_entry_t make_pme(u64 frame, u64 flags)
        return (pagemap_entry_t) { .pme = (frame & PM_PFRAME_MASK) | flags };
 }
 
-static int add_to_pagemap(unsigned long addr, pagemap_entry_t *pme,
-                         struct pagemapread *pm)
+static int add_to_pagemap(pagemap_entry_t *pme, struct pagemapread *pm)
 {
        pm->buffer[pm->pos++] = *pme;
        if (pm->pos >= pm->len)
@@ -1380,7 +1379,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end,
                        hole_end = end;
 
                for (; addr < hole_end; addr += PAGE_SIZE) {
-                       err = add_to_pagemap(addr, &pme, pm);
+                       err = add_to_pagemap(&pme, pm);
                        if (err)
                                goto out;
                }
@@ -1392,7 +1391,7 @@ static int pagemap_pte_hole(unsigned long start, unsigned long end,
                if (vma->vm_flags & VM_SOFTDIRTY)
                        pme = make_pme(0, PM_SOFT_DIRTY);
                for (; addr < min(end, vma->vm_end); addr += PAGE_SIZE) {
-                       err = add_to_pagemap(addr, &pme, pm);
+                       err = add_to_pagemap(&pme, pm);
                        if (err)
                                goto out;
                }
@@ -1519,7 +1518,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
                for (; addr != end; addr += PAGE_SIZE) {
                        pagemap_entry_t pme = make_pme(frame, flags);
 
-                       err = add_to_pagemap(addr, &pme, pm);
+                       err = add_to_pagemap(&pme, pm);
                        if (err)
                                break;
                        if (pm->show_pfn) {
@@ -1547,7 +1546,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
                pagemap_entry_t pme;
 
                pme = pte_to_pagemap_entry(pm, vma, addr, ptep_get(pte));
-               err = add_to_pagemap(addr, &pme, pm);
+               err = add_to_pagemap(&pme, pm);
                if (err)
                        break;
        }
@@ -1597,7 +1596,7 @@ static int pagemap_hugetlb_range(pte_t *ptep, unsigned long hmask,
        for (; addr != end; addr += PAGE_SIZE) {
                pagemap_entry_t pme = make_pme(frame, flags);
 
-               err = add_to_pagemap(addr, &pme, pm);
+               err = add_to_pagemap(&pme, pm);
                if (err)
                        return err;
                if (pm->show_pfn && (flags & PM_PRESENT))