platform/x86: intel_skl_int3472: Uninitialized variable in skl_int3472_handle_gpio_re...

This function returns negative error codes, zero (to indicate that
everything has been completed successfully) and one (to indicate that
more resources need to be handled still).

This code prints an uninitialized error message when the function
returns one which potentially leads to an Oops.

Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
Link: https://lore.kernel.org/r/YNXTkLNtiTDlFlZa@mwanda
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
index 17c6fe83076529f9eda78f404b9263ced78321ea..9fe0a2527e1cd2c5d449d7f2468c9c7b81177b61 100644 (file)
--- a/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
+++ b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
@@ -286,10 +286,10 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
        int3472->ngpios++;
        ACPI_FREE(obj);
 
-       if (ret)
+       if (ret < 0)
                return dev_err_probe(int3472->dev, ret, err_msg);
 
-       return 0;
+       return ret;
 }
 
 static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472)