scripts: get_abi.pl: stop check loop earlier when regex is found
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 23 Sep 2021 15:41:17 +0000 (17:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Sep 2021 16:45:08 +0000 (18:45 +0200)
Right now, there are two loops used to seek for a regex. Make
sure that both will be skip when a match is found.

While here, drop the unused $defined variable.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/2ba722d2cdbe7c7d0f1d1b58d350052576d1d703.1632411447.git.mchehab+huawei@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
scripts/get_abi.pl

index 42eb16eb78e91a7a32a4bc4c5d5b2f83cd9a43c0..d45e5ba56f9cf05e89a8ee1d0518362d2df316cd 100755 (executable)
@@ -685,7 +685,6 @@ sub check_undefined_symbols {
                my @names = @{$$file_ref{"__name"}};
                my $file = $names[0];
 
-               my $defined = 0;
                my $exact = 0;
                my $found_string;
 
@@ -711,13 +710,11 @@ sub check_undefined_symbols {
                                        last;
                                }
                        }
+                       last if ($exact);
                }
-
-               $defined++;
-
                next if ($exact);
 
-               if ($hint && $defined && (!$search_string || $found_string)) {
+               if ($hint && (!$search_string || $found_string)) {
                        $what =~ s/\xac/\n\t/g;
                        if ($leave ne "others") {
                                print "    more likely regexes:\n\t$what\n";