iio: adc: dln2: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-8-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c
index 97d162a3cba4eaaec1442718898d539698529951..06cfbbabaf8dcbf6a40b64a1bd5af790ff9a81f7 100644 (file)
--- a/drivers/iio/adc/dln2-adc.c
+++ b/drivers/iio/adc/dln2-adc.c
@@ -691,19 +691,18 @@ unregister_event:
        return ret;
 }
 
-static int dln2_adc_remove(struct platform_device *pdev)
+static void dln2_adc_remove(struct platform_device *pdev)
 {
        struct iio_dev *indio_dev = platform_get_drvdata(pdev);
 
        iio_device_unregister(indio_dev);
        dln2_unregister_event_cb(pdev, DLN2_ADC_CONDITION_MET_EV);
-       return 0;
 }
 
 static struct platform_driver dln2_adc_driver = {
        .driver.name    = DLN2_ADC_MOD_NAME,
        .probe          = dln2_adc_probe,
-       .remove         = dln2_adc_remove,
+       .remove_new     = dln2_adc_remove,
 };
 
 module_platform_driver(dln2_adc_driver);