ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:28:55 +0000 (22:28 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Tue, 29 Dec 2020 15:43:56 +0000 (16:43 +0100)
The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for ARTIK5 module")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20201210212903.216728-1-krzk@kernel.org
arch/arm/boot/dts/exynos3250-artik5.dtsi

index 04290ec4583a6c82bd6f96ab2a0e5a9dc7cdbe8a..829c05b2c405f4e43ea43f28e3ed585a1c97ddf4 100644 (file)
@@ -79,7 +79,7 @@
        pmic@66 {
                compatible = "samsung,s2mps14-pmic";
                interrupt-parent = <&gpx3>;
-               interrupts = <5 IRQ_TYPE_NONE>;
+               interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
                pinctrl-names = "default";
                pinctrl-0 = <&s2mps14_irq>;
                reg = <0x66>;