tty: make tty_set_operations an inline
authorJiri Slaby <jslaby@suse.cz>
Fri, 23 Jul 2021 07:43:15 +0000 (09:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jul 2021 10:17:21 +0000 (12:17 +0200)
Since commit f34d7a5b7010 (tty: The big operations rework) in 2008,
tty_set_operations() is a simple one-line assignment. There is no reason
for this to be an exported function, hence move it to a header and make
an inline from that.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210723074317.32690-7-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c
include/linux/tty_driver.h

index 26debec26b4e18785c00fa6cfbff063481911492..16e3fce6f88dc78e77978dae8d71253750117c83 100644 (file)
@@ -3438,13 +3438,6 @@ void tty_driver_kref_put(struct tty_driver *driver)
 }
 EXPORT_SYMBOL(tty_driver_kref_put);
 
-void tty_set_operations(struct tty_driver *driver,
-                       const struct tty_operations *op)
-{
-       driver->ops = op;
-};
-EXPORT_SYMBOL(tty_set_operations);
-
 void put_tty_driver(struct tty_driver *d)
 {
        tty_driver_kref_put(d);
index c7746dee58a6415eb37a683aa2a5660608ada09f..6092ce9180aad2887931b6e7ee95e8e2366db524 100644 (file)
@@ -330,8 +330,6 @@ extern struct list_head tty_drivers;
 extern struct tty_driver *__tty_alloc_driver(unsigned int lines,
                struct module *owner, unsigned long flags);
 extern void put_tty_driver(struct tty_driver *driver);
-extern void tty_set_operations(struct tty_driver *driver,
-                       const struct tty_operations *op);
 extern struct tty_driver *tty_find_polling_driver(char *name, int *line);
 
 extern void tty_driver_kref_put(struct tty_driver *driver);
@@ -346,6 +344,12 @@ static inline struct tty_driver *tty_driver_kref_get(struct tty_driver *d)
        return d;
 }
 
+static inline void tty_set_operations(struct tty_driver *driver,
+               const struct tty_operations *op)
+{
+       driver->ops = op;
+}
+
 /* tty driver magic number */
 #define TTY_DRIVER_MAGIC               0x5402