staging: r8188eu: remove unnecessary variable in ioctl_linux
authorKang Minchul <tegongkang@gmail.com>
Tue, 25 Oct 2022 17:06:18 +0000 (02:06 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Oct 2022 08:05:17 +0000 (09:05 +0100)
Returning value 0 directly instead of storing it in variable ret.
This commit can prevent cocci warning as follows:

  Unneeded variable: "ret". Return "0" on line 3030

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Kang Minchul <tegongkang@gmail.com>
Link: https://lore.kernel.org/r/20221025170621.271903-2-tegongkang@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/os_dep/ioctl_linux.c

index 22aab3f986b4d370665caf603251470e754d0c18..f3b3d746853901493b739c08aeb2c7daad4c0b8f 100644 (file)
@@ -2979,8 +2979,6 @@ static int rtw_p2p_set(struct net_device *dev,
                               struct iw_request_info *info,
                               union iwreq_data *wrqu, char *extra)
 {
-       int ret = 0;
-
        if (!memcmp(extra, "enable =", 7)) {
                rtw_wext_p2p_enable(dev, info, wrqu, &extra[7]);
        } else if (!memcmp(extra, "setDN =", 6)) {
@@ -3027,7 +3025,7 @@ static int rtw_p2p_set(struct net_device *dev,
                rtw_p2p_set_persistent(dev, info, wrqu, &extra[11]);
        }
 
-       return ret;
+       return 0;
 }
 
 static int rtw_p2p_get2(struct net_device *dev,