ASoC: dapm: debugfs: add component to route lines
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 16 Apr 2024 06:00:24 +0000 (08:00 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 21 Apr 2024 00:58:15 +0000 (09:58 +0900)
debugfs entries for DAPM widgets have the following form:

  Left ADC: Off  in 1 out 0 - R2(0x2) mask 0x2
   stream Left HiFi Capture inactive
   out  "static" "Capture"
   in  "static" "Left PGA"

Lines with the "in" and "out" prefixes describe routes from/to other
widgets presenting the path name and the connected widget name.

This is ambiguous in case of cards having multiple widgets with the same
name in different components. For example the STM32MP157A-DK1 board
(arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi) has a "Capture" widget in both
the "cs42l51.0-004a" and the "hdmi-audio-codec.1.auto" components.

Avoid the ambiguity by adding the component name to the "in" and "out"
lines. Add the new field at the end to minimize backward compatibility
issues. The existing vizdapm tool continues working after this change.

The output becomes:

  Left ADC: Off  in 1 out 0 - R2(0x2) mask 0x2
   stream Left HiFi Capture inactive
   out  "static" "Capture" "cs42l51.0-004a"
   in  "static" "Left PGA" "cs42l51.0-004a"

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20240416-vizdapm-ng-v1-1-5d33c0b57bc5@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c

index ad8ba8fbbaeec01db0b30bb5457b89ec66c49a61..eb9535764693bcf9e8cac335652497c5b5f6b4b9 100644 (file)
@@ -2104,6 +2104,7 @@ static ssize_t dapm_widget_power_read_file(struct file *file,
        int in, out;
        ssize_t ret;
        struct snd_soc_dapm_path *p = NULL;
+       const char *c_name;
 
        buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
        if (!buf)
@@ -2145,11 +2146,13 @@ static ssize_t dapm_widget_power_read_file(struct file *file,
                        if (!p->connect)
                                continue;
 
+                       c_name = p->node[rdir]->dapm->component ?
+                               p->node[rdir]->dapm->component->name : NULL;
                        ret += scnprintf(buf + ret, PAGE_SIZE - ret,
-                                       " %s  \"%s\" \"%s\"\n",
+                                       " %s  \"%s\" \"%s\" \"%s\"\n",
                                        (rdir == SND_SOC_DAPM_DIR_IN) ? "in" : "out",
                                        p->name ? p->name : "static",
-                                       p->node[rdir]->name);
+                                       p->node[rdir]->name, c_name);
                }
        }