tty: serial: altera_jtaguart: remove flag from altera_jtaguart_rx_chars()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 15 Nov 2022 07:17:21 +0000 (08:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Nov 2022 16:51:41 +0000 (17:51 +0100)
TTY_NORMAL is the only value it contains, so remove the variable and use
the constant instead.

Cc: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Link: https://lore.kernel.org/r/20221115071724.5185-1-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/altera_jtaguart.c

index aa49553fac5847ea03f47e52c7088fbb2969480f..8d172971158419d60451e576b4ae724e150f707f 100644 (file)
@@ -126,18 +126,17 @@ static void altera_jtaguart_set_termios(struct uart_port *port,
 static void altera_jtaguart_rx_chars(struct altera_jtaguart *pp)
 {
        struct uart_port *port = &pp->port;
-       unsigned char ch, flag;
+       unsigned char ch;
        unsigned long status;
 
        while ((status = readl(port->membase + ALTERA_JTAGUART_DATA_REG)) &
               ALTERA_JTAGUART_DATA_RVALID_MSK) {
                ch = status & ALTERA_JTAGUART_DATA_DATA_MSK;
-               flag = TTY_NORMAL;
                port->icount.rx++;
 
                if (uart_handle_sysrq_char(port, ch))
                        continue;
-               uart_insert_char(port, 0, 0, ch, flag);
+               uart_insert_char(port, 0, 0, ch, TTY_NORMAL);
        }
 
        tty_flip_buffer_push(&port->state->port);