media: imx: capture: Return -EPIPE from __capture_legacy_try_fmt()
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 15 Feb 2021 04:26:47 +0000 (05:26 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Mar 2021 10:59:48 +0000 (11:59 +0100)
The correct return code to report an invalid pipeline configuration is
-EPIPE. Return it instead of -EINVAL from __capture_legacy_try_fmt()
when the capture format doesn't match the media bus format of the
connected subdev.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/imx/imx-media-capture.c

index 954f053497f90d20b61a08f3d0814ccb127b0379..43bf3ac9076a3135754835ae5030e93c48a1295a 100644 (file)
@@ -554,7 +554,7 @@ static int capture_validate_fmt(struct capture_priv *priv)
                priv->vdev.fmt.height != pixfmt.height ||
                priv->vdev.cc->cs != cc->cs ||
                priv->vdev.compose.width != compose.width ||
-               priv->vdev.compose.height != compose.height) ? -EINVAL : 0;
+               priv->vdev.compose.height != compose.height) ? -EPIPE : 0;
 }
 
 static int capture_start_streaming(struct vb2_queue *vq, unsigned int count)