projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dc77692
)
sfc/siena: Remove duplicate check on segments
author
Martin Habets
<habetsm.xilinx@gmail.com>
Thu, 19 May 2022 07:17:15 +0000
(08:17 +0100)
committer
Jakub Kicinski
<kuba@kernel.org>
Fri, 20 May 2022 23:46:49 +0000
(16:46 -0700)
Siena only supports software TSO. This means more code can be deleted,
as pointed out by the Smatch static checker warning:
drivers/net/ethernet/sfc/siena/tx.c:184 __efx_siena_enqueue_skb()
warn: duplicate check 'segments' (previous on line 158)
Fixes: 956f2d86cb37 ("sfc/siena: Remove build references to missing functionality")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link:
https://lore.kernel.org/kernel-janitors/YoH5tJMnwuGTrn1Z@kili/
Signed-off-by: Martin Habets <habetsm.xilinx@gmail.com>
Link:
https://lore.kernel.org/r/165294463549.23865.4557617334650441347.stgit@palantir17.mph.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/siena/tx.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/sfc/siena/tx.c
b/drivers/net/ethernet/sfc/siena/tx.c
index b84b9e348c13cb364d5908fb1c541431b431f035..e166dcb9b99ceaa055a880f57785ee13bfb2a6f9 100644
(file)
--- a/
drivers/net/ethernet/sfc/siena/tx.c
+++ b/
drivers/net/ethernet/sfc/siena/tx.c
@@
-181,14
+181,7
@@
netdev_tx_t __efx_siena_enqueue_skb(struct efx_tx_queue *tx_queue,
if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more))
efx_tx_send_pending(tx_queue->channel);
- if (segments) {
- tx_queue->tso_bursts++;
- tx_queue->tso_packets += segments;
- tx_queue->tx_packets += segments;
- } else {
- tx_queue->tx_packets++;
- }
-
+ tx_queue->tx_packets++;
return NETDEV_TX_OK;