n64cart: pass queue_limits to blk_mq_alloc_disk
authorChristoph Hellwig <hch@lst.de>
Thu, 15 Feb 2024 07:10:50 +0000 (08:10 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 19 Feb 2024 23:58:24 +0000 (16:58 -0700)
Pass the queue limits directly to blk_alloc_disk instead of setting them
one at a time.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Link: https://lore.kernel.org/r/20240215071055.2201424-5-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/n64cart.c

index c64d7ee7a44db5a54c2ec2fbc6af1e3d36b06940..27b2187e7a6d55cad41bec8ee664ca7cc5026c28 100644 (file)
@@ -114,6 +114,10 @@ static const struct block_device_operations n64cart_fops = {
  */
 static int __init n64cart_probe(struct platform_device *pdev)
 {
+       struct queue_limits lim = {
+               .physical_block_size    = 4096,
+               .logical_block_size     = 4096,
+       };
        struct gendisk *disk;
        int err = -ENOMEM;
 
@@ -131,7 +135,7 @@ static int __init n64cart_probe(struct platform_device *pdev)
        if (IS_ERR(reg_base))
                return PTR_ERR(reg_base);
 
-       disk = blk_alloc_disk(NULL, NUMA_NO_NODE);
+       disk = blk_alloc_disk(&lim, NUMA_NO_NODE);
        if (IS_ERR(disk)) {
                err = PTR_ERR(disk);
                goto out;
@@ -147,8 +151,6 @@ static int __init n64cart_probe(struct platform_device *pdev)
        set_disk_ro(disk, 1);
 
        blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
-       blk_queue_physical_block_size(disk->queue, 4096);
-       blk_queue_logical_block_size(disk->queue, 4096);
 
        err = add_disk(disk);
        if (err)