pcmcia: ds: Remove if with always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 1 Mar 2021 17:38:47 +0000 (18:38 +0100)
committerDominik Brodowski <linux@dominikbrodowski.net>
Mon, 15 Mar 2021 07:21:46 +0000 (08:21 +0100)
pcmcia_device_remove() is only ever called by the driver core with
dev->driver pointing to a valid driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
[linux@dominikbrodowski.net: shorten commit message, fix reference
 to pcmcia_device_probe]
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
drivers/pcmcia/ds.c

index 72114907c0e4d20f28168b33f313e86c5990d987..6ecb64140f376950bbf1c069659cd6e12725ef1b 100644 (file)
@@ -371,9 +371,6 @@ static int pcmcia_device_remove(struct device *dev)
                pcmcia_card_remove(p_dev->socket, p_dev);
 
        /* detach the "instance" */
-       if (!p_drv)
-               return 0;
-
        if (p_drv->remove)
                p_drv->remove(p_dev);
 
@@ -389,7 +386,7 @@ static int pcmcia_device_remove(struct device *dev)
                                 "pcmcia: driver %s did not release window properly\n",
                                 p_drv->name);
 
-       /* references from pcmcia_probe_device */
+       /* references from pcmcia_device_probe */
        pcmcia_put_dev(p_dev);
        module_put(p_drv->owner);