projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1f8ff52
)
most: usb: replace snprintf in show functions with sysfs_emit
author
Jing Yao
<yao.jing2@zte.com.cn>
Wed, 10 Nov 2021 02:53:41 +0000
(
02:53
+0000)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 16:03:47 +0000
(17:03 +0100)
coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf
Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
sense.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
Link:
https://lore.kernel.org/r/20211110025341.136194-1-yao.jing2@zte.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/most/most_usb.c
patch
|
blob
|
history
diff --git
a/drivers/most/most_usb.c
b/drivers/most/most_usb.c
index acabb7715b42327e5cd7a2aa70e01c161ca173b5..73258b24fea760272d8bd78309df2b5fa17be181 100644
(file)
--- a/
drivers/most/most_usb.c
+++ b/
drivers/most/most_usb.c
@@
-831,7
+831,7
@@
static ssize_t value_show(struct device *dev, struct device_attribute *attr,
int err;
if (sysfs_streq(name, "arb_address"))
- return s
nprintf(buf, PAGE_SIZE
, "%04x\n", dci_obj->reg_addr);
+ return s
ysfs_emit(buf
, "%04x\n", dci_obj->reg_addr);
if (sysfs_streq(name, "arb_value"))
reg_addr = dci_obj->reg_addr;
@@
-843,7
+843,7
@@
static ssize_t value_show(struct device *dev, struct device_attribute *attr,
if (err < 0)
return err;
- return s
nprintf(buf, PAGE_SIZE
, "%04x\n", val);
+ return s
ysfs_emit(buf
, "%04x\n", val);
}
static ssize_t value_store(struct device *dev, struct device_attribute *attr,