exec/exec-all: Move 'qemu/log.h' include in units requiring it
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Mon, 7 Feb 2022 08:27:56 +0000 (09:27 +0100)
committerThomas Huth <thuth@redhat.com>
Mon, 21 Feb 2022 09:18:06 +0000 (10:18 +0100)
Many files use "qemu/log.h" declarations but neglect to include
it (they inherit it via "exec/exec-all.h"). "exec/exec-all.h" is
a core component and shouldn't be used that way. Move the
"qemu/log.h" inclusion locally to each unit requiring it.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220207082756.82600-10-f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
47 files changed:
bsd-user/signal.c
hw/arm/omap1.c
hw/display/omap_dss.c
hw/gpio/omap_gpio.c
hw/input/tsc210x.c
include/exec/exec-all.h
monitor/misc.c
plugins/api.c
softmmu/runstate.c
target/alpha/helper.c
target/arm/helper.c
target/arm/m_helper.c
target/arm/mte_helper.c
target/avr/helper.c
target/cris/helper.c
target/hexagon/internal.h
target/hexagon/translate.h
target/hppa/helper.c
target/hppa/mem_helper.c
target/hppa/op_helper.c
target/i386/helper.c
target/i386/tcg/int_helper.c
target/i386/tcg/misc_helper.c
target/i386/tcg/sysemu/seg_helper.c
target/i386/tcg/sysemu/svm_helper.c
target/m68k/op_helper.c
target/microblaze/cpu.c
target/microblaze/mmu.c
target/microblaze/op_helper.c
target/mips/tcg/exception.c
target/mips/tcg/sysemu/special_helper.c
target/mips/tcg/translate.h
target/openrisc/interrupt.c
target/openrisc/mmu.c
target/ppc/excp_helper.c
target/ppc/misc_helper.c
target/s390x/tcg/excp_helper.c
target/s390x/tcg/mem_helper.c
target/sparc/ldst_helper.c
target/sparc/mmu_helper.c
target/tricore/helper.c
target/xtensa/dbg_helper.c
target/xtensa/exc_helper.c
target/xtensa/fpu_helper.c
target/xtensa/helper.c
target/xtensa/mmu_helper.c
target/xtensa/win_helper.c

index 0bc6d2edbd9312f140acffb133d5bc841ae41f83..8a36b696d82bd94d34757716ec1d6bd6e4259ff1 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu.h"
 #include "signal-common.h"
 #include "trace.h"
index 9852c2a07ec4429d08942d113e3a584481f176c7..f693faa43e08d34b072e665a7347a61511d03eb4 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu/error-report.h"
 #include "qemu/main-loop.h"
 #include "qapi/error.h"
index 21fde58a2602fd4878cdfe227038e545dd01d17f..8c0e9ee70077d12f7c20a990efd91dd2cde2c385 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "hw/hw.h"
 #include "hw/irq.h"
 #include "ui/console.h"
index e25084b40c9550733436c77f18fd34a3a67fcd79..bd0841d57fe03f36132356615fd83d30e8a8f0cd 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "hw/irq.h"
 #include "hw/qdev-properties.h"
 #include "hw/arm/omap.h"
index 182d3725fc96d55694484e27d4cdb3e52d2e02ed..b0d5c2dd748c8201a89a555ed12767e5d025f5a2 100644 (file)
@@ -20,6 +20,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "hw/hw.h"
 #include "audio/audio.h"
 #include "qemu/timer.h"
index 35d8e93976f5c86075afb99b1b3d055a22f3f4ae..227e10ba560db9c33f84a4c00ade43c98b2c2393 100644 (file)
@@ -40,8 +40,6 @@ typedef ram_addr_t tb_page_addr_t;
 #define TB_PAGE_ADDR_FMT RAM_ADDR_FMT
 #endif
 
-#include "qemu/log.h"
-
 void gen_intermediate_code(CPUState *cpu, TranslationBlock *tb, int max_insns);
 void restore_state_to_opc(CPUArchState *env, TranslationBlock *tb,
                           target_ulong *data);
index a3a6e478444e80200d325e28075cf26c7a5b793b..b1839cb8ee5d36857023b52390a07107b2495c74 100644 (file)
@@ -41,6 +41,7 @@
 #include "disas/disas.h"
 #include "sysemu/balloon.h"
 #include "qemu/timer.h"
+#include "qemu/log.h"
 #include "sysemu/hw_accel.h"
 #include "sysemu/runstate.h"
 #include "authz/list.h"
index 91e0c7074c6e1908fd8d546f58962615b95bf86e..7bf71b189dd0a451a9a986411b7e3c03fcd0499b 100644 (file)
@@ -36,6 +36,7 @@
 
 #include "qemu/osdep.h"
 #include "qemu/plugin.h"
+#include "qemu/log.h"
 #include "tcg/tcg.h"
 #include "exec/exec-all.h"
 #include "exec/ram_addr.h"
index 3cb2758b33222114dafcf1b67b84c2e15815c4e6..e0d869b21aa4eda94da8add127cf40480a895b7c 100644 (file)
@@ -42,6 +42,7 @@
 #include "qapi/qapi-events-run-state.h"
 #include "qemu-common.h"
 #include "qemu/error-report.h"
+#include "qemu/log.h"
 #include "qemu/job.h"
 #include "qemu/log.h"
 #include "qemu/module.h"
index b7e7f73b15cc2a08f82ce65d34764616fe8a69f7..dcaa2d03adb39525176e0cf6dda8d894c75711af 100644 (file)
@@ -18,7 +18,7 @@
  */
 
 #include "qemu/osdep.h"
-
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "fpu/softfloat-types.h"
index 795b35532fc8790fac28f55e235f02ea99f607c7..7bf50fdd76fc9c4c348601d2197333490eb84086 100644 (file)
@@ -8,6 +8,7 @@
 
 #include "qemu/osdep.h"
 #include "qemu/units.h"
+#include "qemu/log.h"
 #include "target/arm/idau.h"
 #include "trace.h"
 #include "cpu.h"
index b11e927df1da4fa0878b1172b76c7ec71ede3211..648a3b3fc1685d4370ea40301d933c06b619d944 100644 (file)
@@ -19,6 +19,7 @@
 #include "qemu/bitops.h"
 #include "qemu/crc32c.h"
 #include "qemu/qemu-print.h"
+#include "qemu/log.h"
 #include "exec/exec-all.h"
 #include <zlib.h> /* For crc32 */
 #include "semihosting/semihost.h"
index e09b7e46a2ff61e33dc6067cd463704de15fc7d3..d11a8c70d041622f64e02dc8df1e08880331cc70 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "internals.h"
 #include "exec/exec-all.h"
index 981c29da45358f4ca0211e4940a1967e2ab53c68..c27f7029010ff6260f9e47d1dd46fe7008253071 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "hw/core/tcg-cpu-ops.h"
 #include "exec/exec-all.h"
index a0d6ecdcd39ef7a212c939987ea0c0794653487d..91e4aeb17806d7349e5024a8972997121adda567 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "hw/core/tcg-cpu-ops.h"
 #include "mmu.h"
index 82ac3042ab399fb35950d4fac3d7c22d1de332fe..b1bfadc3f56a85a2d54739ee320f7128d5d29b0b 100644 (file)
@@ -18,6 +18,8 @@
 #ifndef HEXAGON_INTERNAL_H
 #define HEXAGON_INTERNAL_H
 
+#include "qemu/log.h"
+
 /*
  * Change HEX_DEBUG to 1 to turn on debugging output
  */
index fccfb943406ff0fe351ad391841073743a1b8dc4..a2451728277d6402e528d98ee7405083ff11be37 100644 (file)
@@ -19,6 +19,7 @@
 #define HEXAGON_TRANSLATE_H
 
 #include "qemu/bitmap.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/translator.h"
 #include "tcg/tcg-op.h"
index 1ccff5765a80a999a2100ba72a0456b086b44efa..e2758d8df3807fbea5108b80beac0af1738cb275 100644 (file)
@@ -18,7 +18,7 @@
  */
 
 #include "qemu/osdep.h"
-
+#include "qemu/log.h"
 #include "cpu.h"
 #include "fpu/softfloat.h"
 #include "exec/exec-all.h"
index bf07445cd12c9668c36d1362eebcc15265f3aa0a..5046cc8f9d37cd949d175254252090f62859f36e 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "exec/helper-proto.h"
index b0dec4ebf468b0fe1a4f8ed7bc979e1c507c1a7e..2810361be0b7083d309ddc889eba6b3e4b9da49e 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "exec/helper-proto.h"
index 533b29cb91b6036f97befa2e8d05d4fb1369cec8..0639aea11be2408371c8b829f9fb2c71cc607d09 100644 (file)
@@ -27,6 +27,7 @@
 #include "sysemu/hw_accel.h"
 #include "monitor/monitor.h"
 #endif
+#include "qemu/log.h"
 
 void cpu_sync_bndcs_hflags(CPUX86State *env)
 {
index 87fa7280eec7176d1d5ad2e4bf53ee08898e6b98..599ac968b0aa5aadba514645b72280652a90b8b5 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "qemu/host-utils.h"
index 5769db5ace80543710a23bcaaaf6fe5c5c75d99c..24a0eaa3d5964839ee734e311633c639427797e3 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
 #include "exec/exec-all.h"
index 824b9a5a2695aa02c53e41b6c374705bb4a1e713..2c9bd007adbd3a17fed86d35bdb224a2f814484f 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
 #include "exec/cpu_ldst.h"
index 6d39611eb64fd08256eea6ef13a3b2e41a5bf802..2b6f450af95981b2fa5b3d1e310cd2511cbd24cb 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
 #include "exec/exec-all.h"
index acbd4735154e316c359efcb077847787cb73b423..8decc612409cc2e6783e4aa72e742e06fd62b7a5 100644 (file)
@@ -17,6 +17,7 @@
  * License along with this library; if not, see <http://www.gnu.org/licenses/>.
  */
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
 #include "exec/exec-all.h"
index b9c888b87e0cfbcc8c02c9f9c2ec49ee28288598..aed200dcff83bcb3dadc92875e54ce325a76388e 100644 (file)
@@ -22,6 +22,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qapi/error.h"
 #include "cpu.h"
 #include "qemu/module.h"
index cc40f275eaf59ea34d244f4e3d2d74bedfbc5b56..75651979a99f5622bca1f6b509d51d12551a4de8 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 
index 58d633584d37fb62fc7ac35c605e752861cca8fc..5b745d09280db5104db50c1d5bf2a1ba43131363 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
 #include "qemu/host-utils.h"
index 7b3026b105b888cc05ca38a24517372cb5d00efd..0b21e0872bd14978a9828121db4bc132ab5a96ca 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "internal.h"
 #include "exec/helper-proto.h"
index 2a2afb49e81010a70c7fd20e118bff6b43216b08..f4f8fe8afce20c6c0d2ac0ef54d814c9ea67a62c 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
 #include "exec/exec-all.h"
index ae01515efe113adb241a37eed71bcabb1d4fc8e9..9997fe2f3c2a093762b4bede8678aafcb4a4ad22 100644 (file)
@@ -8,6 +8,7 @@
 #ifndef TARGET_MIPS_TRANSLATE_H
 #define TARGET_MIPS_TRANSLATE_H
 
+#include "qemu/log.h"
 #include "exec/translator.h"
 
 #define MIPS_DEBUG_DISAS 0
index 19223e3f25ba5173a56b540d45de827bbc404491..e5724f5371955df783150e9ae9af5164e6c9b07c 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "exec/gdbstub.h"
index e561ef245b4e220fe7f10dff759454d8c2e67794..d7e1320998ebd3b33829b091b077ebbecf159896 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "exec/gdbstub.h"
index f44b9da2a53c0808341edc3661ef8665f3f557dc..6538c56ab02bbd2a34ff16ccff8e4209412747cf 100644 (file)
@@ -18,6 +18,7 @@
  */
 #include "qemu/osdep.h"
 #include "qemu/main-loop.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "internal.h"
index 29e73a6ffda3aa0b7aa58ea4e2be2ebe9a32fc19..06aa716cab7afb1a2a7b8141c44687f9744bcd69 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "exec/helper-proto.h"
index 4e7648f301b3a415fccc649c98b73c97eb5b3fbb..be6c966cfa4c89d9d6abe22060519507cbd62c5b 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "s390x-internal.h"
 #include "exec/helper-proto.h"
index 406578d1053794dddada8f5d0c61397725959242..b5523ef3c752b74ca653b5cc4a1c9a3639e74c71 100644 (file)
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "s390x-internal.h"
 #include "tcg_s390x.h"
index a3e1cf9b6e9dd60d335b8d83fef261e4696a0415..ec4fae78c3c41dd518c3094f8a254bb93e1b5929 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "tcg/tcg.h"
 #include "exec/helper-proto.h"
index f2668389b07a1446bee7119e633685292921feb8..346a6dfa3537c57704de3a3b6dbe5609cc7c6731 100644 (file)
@@ -18,6 +18,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "qemu/qemu-print.h"
index c5e997f3215bcf398d8f22a6c113cadc2120f222..1db32808e818865edf1c9c557adeb4a2cba5eb92 100644 (file)
@@ -16,7 +16,7 @@
  */
 
 #include "qemu/osdep.h"
-
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "fpu/softfloat-helpers.h"
index be1f81107b434c78a04cb5d5fef6f4282156d0cb..ce2a820c60d2382bff5281e063e098b832193a97 100644 (file)
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
index 9bc7f50d35593162fd387132bead9d6756591a2f..d4823a65cdadd1aca4944abab1b29ff4890f244a 100644 (file)
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
index ba3c29d19d9171cac5f304c3281980db753c460b..d2a10cc797302ec54945e933d776fd0d16a6d421 100644 (file)
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"
index 29d216ec1b2e969e93bd8e0e7d691d434f1f98b7..e0a9caab4bfd60064923901a7ababe6b223aebec 100644 (file)
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "cpu.h"
 #include "exec/exec-all.h"
 #include "exec/gdbstub.h"
index 57e319a1af3a04d627028afdff45c24815e083a8..fa66e8e8675141e51ca0f17e3f0a9c7fc1d23650 100644 (file)
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "qemu/qemu-print.h"
 #include "qemu/units.h"
index f6f96a64c30e9e5ae8c574f54e246c6ba6009381..5a1555360a49c20e647154b65a97788b2a1d3633 100644 (file)
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "cpu.h"
 #include "exec/helper-proto.h"