PCI: Clarify intent of LT wait
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 23 Apr 2024 13:08:20 +0000 (16:08 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 25 Apr 2024 17:53:29 +0000 (12:53 -0500)
Clarify the comment relating to the LT wait and the purpose of the check
that implements the implementation note in PCIe r6.1 sec 7.5.3.7.

Suggested-by: Maciej W. Rozycki <macro@orcam.me.uk>
Link: https://lore.kernel.org/r/20240423130820.43824-2-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pci.c

index 70b8c87055cb694c59a4f759d0744e8a00ff7ed3..5a25facb3ce7859dced2bba4f727355c5d280b15 100644 (file)
@@ -4625,9 +4625,10 @@ int pcie_retrain_link(struct pci_dev *pdev, bool use_lt)
 
        /*
         * Ensure the updated LNKCTL parameters are used during link
-        * training by checking that there is no ongoing link training to
-        * avoid LTSSM race as recommended in Implementation Note at the
-        * end of PCIe r6.0.1 sec 7.5.3.7.
+        * training by checking that there is no ongoing link training that
+        * may have started before link parameters were changed, so as to
+        * avoid LTSSM race as recommended in Implementation Note at the end
+        * of PCIe r6.1 sec 7.5.3.7.
         */
        rc = pcie_wait_for_link_status(pdev, true, false);
        if (rc)