mailbox: Remove WARN_ON for async_cb.cb in cmdq_exec_done
authorjason-jh.lin <jason-jh.lin@mediatek.com>
Wed, 29 Sep 2021 07:08:07 +0000 (15:08 +0800)
committerJassi Brar <jaswinder.singh@linaro.org>
Sat, 16 Oct 2021 19:39:49 +0000 (14:39 -0500)
Because mtk_drm_crtc_update_config is not using cmdq_pkt_flush_async,
it won't have pkt->async_cb.cb anymore.

So remove the WARN_ON check of pkt->async_cb.cb at cmdq_exec_done.

Fixes: 1b6b0ce2240e ("mailbox: mtk-cmdq: Use mailbox rx_callback")
Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/mtk-cmdq-mailbox.c

index 505b4988680bf5a7b1734518e3157bf4ace1f3d8..4e9517efac2921ef0403cdb825b57793f8e9e5c3 100644 (file)
@@ -195,7 +195,6 @@ static void cmdq_task_exec_done(struct cmdq_task *task, int sta)
        struct cmdq_task_cb *cb = &task->pkt->async_cb;
        struct cmdq_cb_data data;
 
-       WARN_ON(cb->cb == (cmdq_async_flush_cb)NULL);
        data.sta = sta;
        data.data = cb->data;
        data.pkt = task->pkt;