usb: musb: dsps: Use platform_get_irq_byname() to get the interrupt
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Mon, 20 Dec 2021 01:04:11 +0000 (01:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Dec 2021 07:51:57 +0000 (08:51 +0100)
platform_get_resource_byname(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq_byname().

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20211220010411.12075-7-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/musb_dsps.c

index b5935834f9d2414709d4b50bc8e9465fcb8e9f8b..f75cde0f2b43d6d7ec02da55812bc3e5ef8a2747 100644 (file)
@@ -15,6 +15,7 @@
  */
 
 #include <linux/io.h>
+#include <linux/irq.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>
@@ -739,12 +740,14 @@ static int dsps_create_musb_pdev(struct dsps_glue *glue,
        }
        resources[0] = *res;
 
-       res = platform_get_resource_byname(parent, IORESOURCE_IRQ, "mc");
-       if (!res) {
-               dev_err(dev, "failed to get irq.\n");
-               return -EINVAL;
-       }
-       resources[1] = *res;
+       ret = platform_get_irq_byname(parent, "mc");
+       if (ret < 0)
+               return ret;
+
+       resources[1].start = ret;
+       resources[1].end = ret;
+       resources[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(ret);
+       resources[1].name = "mc";
 
        /* allocate the child platform device */
        musb = platform_device_alloc("musb-hdrc",