drm/bridge: tc358775: Add support for tc358765

The tc358775 bridge is pin compatible with earlier tc358765 according to
the tc358774xbg_datasheet_en_20190118.pdf documentation. Compared to the
tc358765, the tc358775 supports a STBY GPIO and higher data rates.

The tc358765 has a register bit for video event mode vs video pulse mode.
We must set it to video event mode for the LCD output to work, and on the
tc358775, this bit no longer exists.

Looks like the registers seem to match otherwise based on a quick glance
comparing the defines to the earlier Android kernel tc358765 driver.

Reviewed-by: Michael Walle <mwalle@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240225062008.33191-10-tony@atomide.com

diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
index 14bf8be90929eff0bc3739bc76f95bd63fc373e3..17a91510019b8d6f1ab24e05baf3b7808c89b353 100644 (file)
--- a/drivers/gpu/drm/bridge/tc358775.c
+++ b/drivers/gpu/drm/bridge/tc358775.c
@@ -15,6 +15,7 @@
 #include <linux/kernel.h>
 #include <linux/media-bus-format.h>
 #include <linux/module.h>
+#include <linux/of_device.h>
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
 
@@ -107,6 +108,7 @@
 #define RDPKTLN         0x0404  /* Command Read Packet Length */
 
 #define VPCTRL          0x0450  /* Video Path Control */
+#define EVTMODE                BIT(5)  /* Video event mode enable, tc35876x only */
 #define HTIM1           0x0454  /* Horizontal Timing Control 1 */
 #define HTIM2           0x0458  /* Horizontal Timing Control 2 */
 #define VTIM1           0x045C  /* Vertical Timing Control 1 */
@@ -254,6 +256,11 @@ enum tc358775_ports {
        TC358775_LVDS_OUT1,
 };
 
+enum tc3587x5_type {
+       TC358765 = 0x65,
+       TC358775 = 0x75,
+};
+
 struct tc_data {
        struct i2c_client       *i2c;
        struct device           *dev;
@@ -271,6 +278,8 @@ struct tc_data {
        struct gpio_desc        *stby_gpio;
        u8                      lvds_link; /* single-link or dual-link */
        u8                      bpc;
+
+       enum tc3587x5_type      type;
 };
 
 static inline struct tc_data *bridge_to_tc(struct drm_bridge *b)
@@ -424,10 +433,16 @@ static void tc_bridge_enable(struct drm_bridge *bridge)
        d2l_write(tc->i2c, PPI_STARTPPI, PPI_START_FUNCTION);
        d2l_write(tc->i2c, DSI_STARTDSI, DSI_RX_START);
 
+       /* Video event mode vs pulse mode bit, does not exist for tc358775 */
+       if (tc->type == TC358765)
+               val = EVTMODE;
+       else
+               val = 0;
+
        if (tc->bpc == 8)
-               val = TC358775_VPCTRL_OPXLFMT(1);
+               val |= TC358775_VPCTRL_OPXLFMT(1);
        else /* bpc = 6; */
-               val = TC358775_VPCTRL_MSF(1);
+               val |= TC358775_VPCTRL_MSF(1);
 
        dsiclk = mode->crtc_clock * 3 * tc->bpc / tc->num_dsi_lanes / 1000;
        clkdiv = dsiclk / (tc->lvds_link == DUAL_LINK ? DIVIDE_BY_6 : DIVIDE_BY_3);
@@ -641,6 +656,7 @@ static int tc_probe(struct i2c_client *client)
 
        tc->dev = dev;
        tc->i2c = client;
+       tc->type = (enum tc3587x5_type)(unsigned long)of_device_get_match_data(dev);
 
        tc->panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node,
                                                  TC358775_LVDS_OUT0, 0);
@@ -702,13 +718,15 @@ static void tc_remove(struct i2c_client *client)
 }
 
 static const struct i2c_device_id tc358775_i2c_ids[] = {
-       { "tc358775", 0 },
+       { "tc358765", TC358765, },
+       { "tc358775", TC358775, },
        { }
 };
 MODULE_DEVICE_TABLE(i2c, tc358775_i2c_ids);
 
 static const struct of_device_id tc358775_of_ids[] = {
-       { .compatible = "toshiba,tc358775", },
+       { .compatible = "toshiba,tc358765", .data = (void *)TC358765, },
+       { .compatible = "toshiba,tc358775", .data = (void *)TC358775, },
        { }
 };
 MODULE_DEVICE_TABLE(of, tc358775_of_ids);