firmware: edd: Remove redundant condition

The logic (!A || (A && B)) is equivalent to (!A || B). so we have
to make code clear.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Link: https://lore.kernel.org/r/1650505393-19398-1-git-send-email-baihaowen@meizu.com
Reviewed-by: Griffin Kroah-Hartman <griffin@kroah.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 69353dd0ea2210680c09450ef43ac64e7b088946..5cc238916551a7e5e2134188eb0f587fea8bab6a 100644 (file)
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev)
        int i;
 
        for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
-               if (!attr->test ||
-                   (attr->test && attr->test(edev)))
+               if (!attr->test || attr->test(edev))
                        error = sysfs_create_file(&edev->kobj,&attr->attr);
        }