fail_function: refactor code of checking return value of register_kprobe()

Refactor the error handling of register_kprobe() to improve readability.
No functional change.

Link: https://lkml.kernel.org/r/20220826073337.2085798-2-yangyingliang@huawei.com
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/kernel/fail_function.c b/kernel/fail_function.c
index 03643e33e4c330b33b92913759de360ab73500df..893e8f9a911891e6c65cfd451c01b20dc47a8021 100644 (file)
--- a/kernel/fail_function.c
+++ b/kernel/fail_function.c
@@ -294,14 +294,13 @@ static ssize_t fei_write(struct file *file, const char __user *buffer,
        }
 
        ret = register_kprobe(&attr->kp);
-       if (!ret)
-               fei_debugfs_add_attr(attr);
-       if (ret < 0)
+       if (ret) {
                fei_attr_remove(attr);
-       else {
-               list_add_tail(&attr->list, &fei_attr_list);
-               ret = count;
+               goto out;
        }
+       fei_debugfs_add_attr(attr);
+       list_add_tail(&attr->list, &fei_attr_list);
+       ret = count;
 out:
        mutex_unlock(&fei_lock);
        kfree(buf);