wifi: wfx: move wfx_skb_*() out of the header file
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Wed, 4 Oct 2023 17:28:38 +0000 (19:28 +0200)
committerKalle Valo <kvalo@kernel.org>
Mon, 9 Oct 2023 06:53:06 +0000 (09:53 +0300)
There is no real reasons to keep these function in the header file.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20231004172843.195332-4-jerome.pouiller@silabs.com
drivers/net/wireless/silabs/wfx/data_tx.c
drivers/net/wireless/silabs/wfx/data_tx.h

index 6a5e52a96d183a138c543f03b6cea33732adb5a9..ce2b5dcfd8d89e1a3f4ee915615c3e0c1d5b4ba2 100644 (file)
@@ -208,6 +208,24 @@ static bool wfx_is_action_back(struct ieee80211_hdr *hdr)
        return true;
 }
 
+struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb)
+{
+       struct ieee80211_tx_info *tx_info;
+
+       if (!skb)
+               return NULL;
+       tx_info = IEEE80211_SKB_CB(skb);
+       return (struct wfx_tx_priv *)tx_info->rate_driver_data;
+}
+
+struct wfx_hif_req_tx *wfx_skb_txreq(struct sk_buff *skb)
+{
+       struct wfx_hif_msg *hif = (struct wfx_hif_msg *)skb->data;
+       struct wfx_hif_req_tx *req = (struct wfx_hif_req_tx *)hif->body;
+
+       return req;
+}
+
 static u8 wfx_tx_get_link_id(struct wfx_vif *wvif, struct ieee80211_sta *sta,
                             struct ieee80211_hdr *hdr)
 {
index 983470705e4bbdbff42f7b829608496fa89bea86..a5b80eacce39ace6a1a54442a284f4d18f7354f0 100644 (file)
@@ -45,22 +45,7 @@ void wfx_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control, struc
 void wfx_tx_confirm_cb(struct wfx_dev *wdev, const struct wfx_hif_cnf_tx *arg);
 void wfx_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif, u32 queues, bool drop);
 
-static inline struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb)
-{
-       struct ieee80211_tx_info *tx_info;
-
-       if (!skb)
-               return NULL;
-       tx_info = IEEE80211_SKB_CB(skb);
-       return (struct wfx_tx_priv *)tx_info->rate_driver_data;
-}
-
-static inline struct wfx_hif_req_tx *wfx_skb_txreq(struct sk_buff *skb)
-{
-       struct wfx_hif_msg *hif = (struct wfx_hif_msg *)skb->data;
-       struct wfx_hif_req_tx *req = (struct wfx_hif_req_tx *)hif->body;
-
-       return req;
-}
+struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb);
+struct wfx_hif_req_tx *wfx_skb_txreq(struct sk_buff *skb);
 
 #endif