scsi: mpt3sas: Fix Coverity reported issue
authorSuganath Prabu S <suganath-prabu.subramani@broadcom.com>
Fri, 18 Jun 2021 15:55:06 +0000 (21:25 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 19 Jun 2021 03:01:03 +0000 (23:01 -0400)
Fix the structurally dead code (UNREACHABLE) type of error reported by
Coverity.

Link: https://lore.kernel.org/r/20210618155506.2609112-1-suganath-prabu.subramani@broadcom.com
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c

index 4df8448cfbf24fccec01ac3744376347c90cc653..c39955239d1ca06c8a2c57a91b561370358a54a9 100644 (file)
@@ -7207,6 +7207,7 @@ mpt3sas_port_enable_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
                ioc->port_enable_failed = 1;
 
        if (ioc->port_enable_cmds.status & MPT3_CMD_COMPLETE_ASYNC) {
+               ioc->port_enable_cmds.status &= ~MPT3_CMD_COMPLETE_ASYNC;
                if (ioc_status == MPI2_IOCSTATUS_SUCCESS) {
                        mpt3sas_port_enable_complete(ioc);
                        return 1;
@@ -7215,7 +7216,6 @@ mpt3sas_port_enable_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index,
                        ioc->start_scan = 0;
                        return 1;
                }
-               ioc->port_enable_cmds.status &= ~MPT3_CMD_COMPLETE_ASYNC;
        }
        complete(&ioc->port_enable_cmds.done);
        return 1;