staging: qlge: add braces on all arms of if-else
authorKaaira Gupta <kgupta@es.iitr.ac.in>
Fri, 21 Feb 2020 20:29:04 +0000 (01:59 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 23 Feb 2020 18:18:33 +0000 (19:18 +0100)
fix all checkpatch.pl warnings of 'braces {} should be used on all arms
of this statement' in the file qlge_ethtool.c by adding the braces.

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
Link: https://lore.kernel.org/r/20200221202904.GA19627@kaaira-HP-Pavilion-Notebook
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_ethtool.c

index 790997aff995d87754917f3d14bd2dfeac71cb9a..592ca7edfc446c52dc2a4e64baef6ebdd833df2f 100644 (file)
@@ -259,8 +259,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
                                  "Error reading status register 0x%.04x.\n",
                                  i);
                        goto end;
-               } else
+               } else {
                        *iter = data;
+               }
                iter++;
        }
 
@@ -273,8 +274,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
                                  "Error reading status register 0x%.04x.\n",
                                  i);
                        goto end;
-               } else
+               } else {
                        *iter = data;
+               }
                iter++;
        }
 
@@ -290,8 +292,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
                                  "Error reading status register 0x%.04x.\n",
                                  i);
                        goto end;
-               } else
+               } else {
                        *iter = data;
+               }
                iter++;
        }
 
@@ -304,8 +307,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
                                  "Error reading status register 0x%.04x.\n",
                                  i);
                        goto end;
-               } else
+               } else {
                        *iter = data;
+               }
                iter++;
        }
 
@@ -316,8 +320,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
                netif_err(qdev, drv, qdev->ndev,
                          "Error reading status register 0x%.04x.\n", i);
                goto end;
-       } else
+       } else {
                *iter = data;
+       }
 end:
        ql_sem_unlock(qdev, qdev->xg_sem_mask);
 quit:
@@ -488,8 +493,9 @@ static int ql_start_loopback(struct ql_adapter *qdev)
        if (netif_carrier_ok(qdev->ndev)) {
                set_bit(QL_LB_LINK_UP, &qdev->flags);
                netif_carrier_off(qdev->ndev);
-       } else
+       } else {
                clear_bit(QL_LB_LINK_UP, &qdev->flags);
+       }
        qdev->link_config |= CFG_LOOPBACK_PCS;
        return ql_mb_set_port_cfg(qdev);
 }