sparc: Annotate struct cpuinfo_tree with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:52:00 +0000 (10:52 -0700)
committerKees Cook <keescook@chromium.org>
Fri, 6 Oct 2023 20:25:17 +0000 (13:25 -0700)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct cpuinfo_tree.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922175159.work.357-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
arch/sparc/kernel/cpumap.c

index f07ea88a83af3126cc87eb9dc5f36033ca4e3cd9..8fcf2d8c6bd2aab2e4977e9feed20e19ce965b93 100644 (file)
@@ -50,7 +50,7 @@ struct cpuinfo_tree {
 
        /* Offsets into nodes[] for each level of the tree */
        struct cpuinfo_level level[CPUINFO_LVL_MAX];
-       struct cpuinfo_node  nodes[];
+       struct cpuinfo_node  nodes[] __counted_by(total_nodes);
 };