eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx()
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fri, 15 Dec 2017 18:41:49 +0000 (18:41 +0000)
committerJason Wang <jasowang@redhat.com>
Fri, 22 Dec 2017 02:01:27 +0000 (10:01 +0800)
This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/eepro100.c

index e30fed830be02ecd53e6f2da1bb47b697dfbe884..a07a63247e8e794233c1b39421bed686f89a5612 100644 (file)
@@ -1679,7 +1679,7 @@ static ssize_t nic_receive(NetClientState *nc, const uint8_t * buf, size_t size)
         rfd_status |= 0x0004;
     } else if (s->configuration[20] & BIT(6)) {
         /* Multiple IA bit set. */
-        unsigned mcast_idx = compute_mcast_idx(buf);
+        unsigned mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
         assert(mcast_idx < 64);
         if (s->mult[mcast_idx >> 3] & (1 << (mcast_idx & 7))) {
             TRACE(RXTX, logout("%p accepted, multiple IA bit set\n", s));