tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
authorXiu Jianfeng <xiujianfeng@huawei.com>
Fri, 18 Mar 2022 06:02:01 +0000 (14:02 +0800)
committerJarkko Sakkinen <jarkko@kernel.org>
Mon, 23 May 2022 15:47:49 +0000 (18:47 +0300)
Currently it returns zero when CRQ response timed out, it should return
an error code instead.

Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_ibmvtpm.c

index 3af4c07a9342ff115a2e3de3561c2b09793a6a6f..d3989b257f4222e2a581e04d58b24cafc569a63f 100644 (file)
@@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
        if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
                                ibmvtpm->rtce_buf != NULL,
                                HZ)) {
+               rc = -ENODEV;
                dev_err(dev, "CRQ response timed out\n");
                goto init_irq_cleanup;
        }