tpm/eventlog: remove redundant assignment to variabel ret
authorColin Ian King <colin.i.king@gmail.com>
Thu, 11 Apr 2024 08:49:13 +0000 (09:49 +0100)
committerJarkko Sakkinen <jarkko@kernel.org>
Thu, 9 May 2024 19:30:50 +0000 (22:30 +0300)
Variable ret is being assigned and error code that is never read, it is
either being re-assigned in an error exit path or never referenced again
on the non-error path. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/char/tpm/eventlog/acpi.c:145:2: warning: Value stored to 'ret'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/eventlog/acpi.c

index bd757d836c5cf9ba53b6355da877d5907e32a8e7..69533d0bfb51e8064efaabaf548b217e0e3be278 100644 (file)
@@ -142,7 +142,6 @@ int tpm_read_log_acpi(struct tpm_chip *chip)
 
        log->bios_event_log_end = log->bios_event_log + len;
 
-       ret = -EIO;
        virt = acpi_os_map_iomem(start, len);
        if (!virt) {
                dev_warn(&chip->dev, "%s: Failed to map ACPI memory\n", __func__);