wifi: iwlwifi: remove memory check for LMAC error address
authorMukesh Sisodiya <mukesh.sisodiya@intel.com>
Wed, 16 Aug 2023 08:10:54 +0000 (11:10 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 22 Aug 2023 11:19:25 +0000 (13:19 +0200)
LMAC error table address was checked against UMAC
error table minimum address defined. Because of that,
the LMAC error table was not read, since both addresses
belong to different ranges. As addresses are updated from
FW alive message and should be correct, this check is not
needed.

Still keep the check for address 0 to avoid NULL address read.

Signed-off-by: Mukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230816104355.08ab1497904d.I270d4c5bcc23c5ecd0b7db475501032c450852ad@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/dump.c

index 5876f917e5361b11d89c7c6d2b5c7106babf0173..8f107ceec40767a56273e4fca8627e1d80cc16d7 100644 (file)
@@ -182,8 +182,7 @@ static void iwl_fwrt_dump_lmac_error_log(struct iwl_fw_runtime *fwrt, u8 lmac_nu
                        base = fwrt->fw->inst_errlog_ptr;
        }
 
-       if ((fwrt->trans->trans_cfg->device_family >= IWL_DEVICE_FAMILY_BZ && !base) ||
-           (fwrt->trans->trans_cfg->device_family < IWL_DEVICE_FAMILY_BZ && base < 0x400000)) {
+       if (!base) {
                IWL_ERR(fwrt,
                        "Not valid error log pointer 0x%08X for %s uCode\n",
                        base,