sched/completions: Use bool in try_wait_for_completion()
authorgaurav jindal <gauravjindal1104@gmail.com>
Wed, 21 Feb 2018 12:54:07 +0000 (18:24 +0530)
committerIngo Molnar <mingo@kernel.org>
Fri, 9 Mar 2018 07:00:18 +0000 (08:00 +0100)
Since the return type of the function is bool, the internal
'ret' variable should be bool too.

Signed-off-by: Gaurav Jindal<gauravjindal1104@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20180221125407.GA14292@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/completion.c

index 5d2d56b0817a1cf81b78c48bd57c8c606107ac07..e426b0cb9ac6314b8e19ada428e81fe1eabea7fb 100644 (file)
@@ -280,7 +280,7 @@ EXPORT_SYMBOL(wait_for_completion_killable_timeout);
 bool try_wait_for_completion(struct completion *x)
 {
        unsigned long flags;
-       int ret = 1;
+       bool ret = true;
 
        /*
         * Since x->done will need to be locked only
@@ -289,11 +289,11 @@ bool try_wait_for_completion(struct completion *x)
         * return early in the blocking case.
         */
        if (!READ_ONCE(x->done))
-               return 0;
+               return false;
 
        spin_lock_irqsave(&x->wait.lock, flags);
        if (!x->done)
-               ret = 0;
+               ret = false;
        else if (x->done != UINT_MAX)
                x->done--;
        spin_unlock_irqrestore(&x->wait.lock, flags);