locking/atomic, mips: Use s64 for atomic64
authorMark Rutland <mark.rutland@arm.com>
Wed, 22 May 2019 13:22:41 +0000 (14:22 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 3 Jun 2019 10:32:56 +0000 (12:32 +0200)
As a step towards making the atomic64 API use consistent types treewide,
let's have the mips atomic64 implementation use s64 as the underlying
type for atomic64_t, rather than long or __s64, matching the generated
headers.

As atomic64_read() depends on the generic defintion of atomic64_t, this
still returns long on 64-bit. This will be converted in a subsequent
patch.

Otherwise, there should be no functional change as a result of this
patch.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
Cc: aou@eecs.berkeley.edu
Cc: arnd@arndb.de
Cc: bp@alien8.de
Cc: catalin.marinas@arm.com
Cc: davem@davemloft.net
Cc: fenghua.yu@intel.com
Cc: heiko.carstens@de.ibm.com
Cc: herbert@gondor.apana.org.au
Cc: ink@jurassic.park.msu.ru
Cc: linux@armlinux.org.uk
Cc: mattst88@gmail.com
Cc: mpe@ellerman.id.au
Cc: palmer@sifive.com
Cc: paulus@samba.org
Cc: rth@twiddle.net
Cc: tony.luck@intel.com
Cc: vgupta@synopsys.com
Link: https://lkml.kernel.org/r/20190522132250.26499-10-mark.rutland@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/mips/include/asm/atomic.h

index 94096299fc569280a6b013a011d22de8c2be6fdd..9a82dd11c0e9ed56ee5363321657513a164529eb 100644 (file)
@@ -254,10 +254,10 @@ static __inline__ int atomic_sub_if_positive(int i, atomic_t * v)
 #define atomic64_set(v, i)     WRITE_ONCE((v)->counter, (i))
 
 #define ATOMIC64_OP(op, c_op, asm_op)                                        \
-static __inline__ void atomic64_##op(long i, atomic64_t * v)                 \
+static __inline__ void atomic64_##op(s64 i, atomic64_t * v)                  \
 {                                                                            \
        if (kernel_uses_llsc) {                                               \
-               long temp;                                                    \
+               s64 temp;                                                     \
                                                                              \
                loongson_llsc_mb();                                           \
                __asm__ __volatile__(                                         \
@@ -280,12 +280,12 @@ static __inline__ void atomic64_##op(long i, atomic64_t * v)                    \
 }
 
 #define ATOMIC64_OP_RETURN(op, c_op, asm_op)                                 \
-static __inline__ long atomic64_##op##_return_relaxed(long i, atomic64_t * v) \
+static __inline__ s64 atomic64_##op##_return_relaxed(s64 i, atomic64_t * v)   \
 {                                                                            \
-       long result;                                                          \
+       s64 result;                                                           \
                                                                              \
        if (kernel_uses_llsc) {                                               \
-               long temp;                                                    \
+               s64 temp;                                                     \
                                                                              \
                loongson_llsc_mb();                                           \
                __asm__ __volatile__(                                         \
@@ -314,12 +314,12 @@ static __inline__ long atomic64_##op##_return_relaxed(long i, atomic64_t * v) \
 }
 
 #define ATOMIC64_FETCH_OP(op, c_op, asm_op)                                  \
-static __inline__ long atomic64_fetch_##op##_relaxed(long i, atomic64_t * v)  \
+static __inline__ s64 atomic64_fetch_##op##_relaxed(s64 i, atomic64_t * v)    \
 {                                                                            \
-       long result;                                                          \
+       s64 result;                                                           \
                                                                              \
        if (kernel_uses_llsc) {                                               \
-               long temp;                                                    \
+               s64 temp;                                                     \
                                                                              \
                loongson_llsc_mb();                                           \
                __asm__ __volatile__(                                         \
@@ -386,14 +386,14 @@ ATOMIC64_OPS(xor, ^=, xor)
  * Atomically test @v and subtract @i if @v is greater or equal than @i.
  * The function returns the old value of @v minus @i.
  */
-static __inline__ long atomic64_sub_if_positive(long i, atomic64_t * v)
+static __inline__ s64 atomic64_sub_if_positive(s64 i, atomic64_t * v)
 {
-       long result;
+       s64 result;
 
        smp_mb__before_llsc();
 
        if (kernel_uses_llsc) {
-               long temp;
+               s64 temp;
 
                __asm__ __volatile__(
                "       .set    push                                    \n"