accel/habanalabs: remove unneeded irq_handler variable
authorTomer Tayar <ttayar@habana.ai>
Thu, 16 Feb 2023 16:16:56 +0000 (18:16 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Wed, 15 Mar 2023 11:29:14 +0000 (13:29 +0200)
'irq_handler' in gaudi2_enable_msix(), is just assigned with a function
name and then used when calling request_threaded_irq().
Remove the variable and use the function name directly as an argument.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
drivers/accel/habanalabs/gaudi2/gaudi2.c

index 202e5e1346e0ad562ddf2c49abd90496030f30fe..dd32840208414fb1b726299a68fb166b9bdf8cea 100644 (file)
@@ -3974,7 +3974,6 @@ static int gaudi2_enable_msix(struct hl_device *hdev)
        struct asic_fixed_properties *prop = &hdev->asic_prop;
        struct gaudi2_device *gaudi2 = hdev->asic_specific;
        int rc, irq, i, j, user_irq_init_cnt;
-       irq_handler_t irq_handler;
        struct hl_cq *cq;
 
        if (gaudi2->hw_cap_initialized & HW_CAP_MSIX)
@@ -4024,10 +4023,9 @@ static int gaudi2_enable_msix(struct hl_device *hdev)
                        i++, j++, user_irq_init_cnt++) {
 
                irq = pci_irq_vector(hdev->pdev, i);
-               irq_handler = hl_irq_handler_user_interrupt;
-
-               rc = request_threaded_irq(irq, irq_handler, hl_irq_user_interrupt_thread_handler,
-                               IRQF_ONESHOT, gaudi2_irq_name(i), &hdev->user_interrupt[j]);
+               rc = request_threaded_irq(irq, hl_irq_handler_user_interrupt,
+                                               hl_irq_user_interrupt_thread_handler, IRQF_ONESHOT,
+                                               gaudi2_irq_name(i), &hdev->user_interrupt[j]);
 
                if (rc) {
                        dev_err(hdev->dev, "Failed to request IRQ %d", irq);