mailbox: tegra-hsp: Set lockdep class dynamically
authorMikko Perttunen <mperttunen@nvidia.com>
Wed, 10 Feb 2021 13:49:45 +0000 (15:49 +0200)
committerJassi Brar <jaswinder.singh@linaro.org>
Mon, 15 Feb 2021 05:28:40 +0000 (23:28 -0600)
On Tegra194, due to both BPMP and TCU using mailboxes, we get a
lockdep spew at boot. Both are using different instances of HSP,
so this is harmless. As such give each HSP instance a different
lockdep class.

Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/tegra-hsp.c

index e07091d71986a5f1ca30dfdfd38c785356e6647b..acd0675da681e9d317a9bed42f887f6f36f695ea 100644 (file)
@@ -98,7 +98,9 @@ struct tegra_hsp {
        unsigned int num_ss;
        unsigned int num_db;
        unsigned int num_si;
+
        spinlock_t lock;
+       struct lock_class_key lock_key;
 
        struct list_head doorbells;
        struct tegra_hsp_mailbox *mailboxes;
@@ -775,6 +777,18 @@ static int tegra_hsp_probe(struct platform_device *pdev)
                        return err;
        }
 
+       lockdep_register_key(&hsp->lock_key);
+       lockdep_set_class(&hsp->lock, &hsp->lock_key);
+
+       return 0;
+}
+
+static int tegra_hsp_remove(struct platform_device *pdev)
+{
+       struct tegra_hsp *hsp = platform_get_drvdata(pdev);
+
+       lockdep_unregister_key(&hsp->lock_key);
+
        return 0;
 }
 
@@ -834,6 +848,7 @@ static struct platform_driver tegra_hsp_driver = {
                .pm = &tegra_hsp_pm_ops,
        },
        .probe = tegra_hsp_probe,
+       .remove = tegra_hsp_remove,
 };
 
 static int __init tegra_hsp_init(void)