Bluetooth: btusb: Add the missed release_firmware() in btusb_mtk_setup_firmware()
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Tue, 17 Nov 2020 02:59:17 +0000 (10:59 +0800)
committerJohan Hedberg <johan.hedberg@intel.com>
Mon, 7 Dec 2020 15:00:08 +0000 (17:00 +0200)
btusb_mtk_setup_firmware() misses to call release_firmware() in an error
path. Jump to err_release_fw to fix it.

Fixes: f645125711c8 ("Bluetooth: btusb: fix up firmware download sequence")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
drivers/bluetooth/btusb.c

index b515b17f450481d7b017ad77c33a8b9b09e216d0..3bbe8f43e7fa8d6b9228b2ecb073b0f2e7eb566e 100644 (file)
@@ -3092,7 +3092,7 @@ static int btusb_mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
        err = btusb_mtk_hci_wmt_sync(hdev, &wmt_params);
        if (err < 0) {
                bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
-               return err;
+               goto err_release_fw;
        }
 
        fw_ptr = fw->data;