btrfs: use assertion instead of BUG_ON when adding/removing to delalloc list

When adding or removing and inode to/from the root's delalloc list,
instead of using a BUG_ON() to validate list emptiness, use ASSERT()
since this is to check logic errors rather than real errors.

Reviewed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 3874edefe9a73459a572c21d2d53791c55e64bd7..04d836673e1270ba31fb853ab75eea7753bb9a5f 100644 (file)
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -2400,7 +2400,7 @@ static void btrfs_add_delalloc_inode(struct btrfs_inode *inode)
        root->nr_delalloc_inodes++;
        if (root->nr_delalloc_inodes == 1) {
                spin_lock(&fs_info->delalloc_root_lock);
-               BUG_ON(!list_empty(&root->delalloc_root));
+               ASSERT(list_empty(&root->delalloc_root));
                list_add_tail(&root->delalloc_root, &fs_info->delalloc_roots);
                spin_unlock(&fs_info->delalloc_root_lock);
        }
@@ -2426,7 +2426,7 @@ void __btrfs_del_delalloc_inode(struct btrfs_inode *inode)
                if (!root->nr_delalloc_inodes) {
                        ASSERT(list_empty(&root->delalloc_inodes));
                        spin_lock(&fs_info->delalloc_root_lock);
-                       BUG_ON(list_empty(&root->delalloc_root));
+                       ASSERT(!list_empty(&root->delalloc_root));
                        list_del_init(&root->delalloc_root);
                        spin_unlock(&fs_info->delalloc_root_lock);
                }