cgroup: Avoid extra dereference in css_populate_dir()
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Tue, 12 Sep 2023 07:04:35 +0000 (12:34 +0530)
committerTejun Heo <tj@kernel.org>
Mon, 18 Sep 2023 18:58:27 +0000 (08:58 -1000)
Use css directly instead of dereferencing it from &cgroup->self, while
adding the cgroup v2 cft base and psi files in css_populate_dir(). Both
points to the same css, when css->ss is NULL, this avoids extra deferences
and makes code consistent in usage across the function.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cgroup.c

index d40d58b963c85230427eda4e43a52a317dca123a..833ac6dd15d9feea64fe4709afbcb112471f5fbe 100644 (file)
@@ -1719,13 +1719,13 @@ static int css_populate_dir(struct cgroup_subsys_state *css)
 
        if (!css->ss) {
                if (cgroup_on_dfl(cgrp)) {
-                       ret = cgroup_addrm_files(&cgrp->self, cgrp,
+                       ret = cgroup_addrm_files(css, cgrp,
                                                 cgroup_base_files, true);
                        if (ret < 0)
                                return ret;
 
                        if (cgroup_psi_enabled()) {
-                               ret = cgroup_addrm_files(&cgrp->self, cgrp,
+                               ret = cgroup_addrm_files(css, cgrp,
                                                         cgroup_psi_files, true);
                                if (ret < 0)
                                        return ret;