iio: adc: meson: improve error logging at probe stage

Add log messages for errors that may occur at the probe stage

Signed-off-by: George Stark <gnstark@sberdevices.ru>
Link: https://lore.kernel.org/r/20230721102413.255726-3-gnstark@sberdevices.ru
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index a40986fb285cae6be8f1c5993157c0d91b0c5848..950ff13e6dde80f652f2e349ac5917b458c0f2c2 100644 (file)
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -1045,8 +1045,10 @@ static int meson_sar_adc_hw_enable(struct iio_dev *indio_dev)
        u32 regval;
 
        ret = meson_sar_adc_lock(indio_dev);
-       if (ret)
+       if (ret) {
+               dev_err(dev, "failed to lock adc\n");
                goto err_lock;
+       }
 
        ret = regulator_enable(priv->vref);
        if (ret < 0) {
@@ -1354,15 +1356,15 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
 
        priv->regmap = devm_regmap_init_mmio(dev, base, priv->param->regmap_config);
        if (IS_ERR(priv->regmap))
-               return PTR_ERR(priv->regmap);
+               return dev_err_probe(dev, PTR_ERR(priv->regmap), "failed to init regmap\n");
 
        irq = irq_of_parse_and_map(dev->of_node, 0);
        if (!irq)
-               return -EINVAL;
+               return dev_err_probe(dev, -EINVAL, "failed to get irq\n");
 
        ret = devm_request_irq(dev, irq, meson_sar_adc_irq, IRQF_SHARED, dev_name(dev), indio_dev);
        if (ret)
-               return ret;
+               return dev_err_probe(dev, ret, "failed to request irq\n");
 
        priv->clkin = devm_clk_get(dev, "clkin");
        if (IS_ERR(priv->clkin))
@@ -1384,7 +1386,7 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
        if (!priv->adc_clk) {
                ret = meson_sar_adc_clk_init(indio_dev, base);
                if (ret)
-                       return ret;
+                       return dev_err_probe(dev, ret, "failed to init internal clk\n");
        }
 
        priv->vref = devm_regulator_get(dev, "vref");
@@ -1426,8 +1428,10 @@ static int meson_sar_adc_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, indio_dev);
 
        ret = iio_device_register(indio_dev);
-       if (ret)
+       if (ret) {
+               dev_err_probe(dev, ret, "failed to register iio device\n");
                goto err_hw;
+       }
 
        return 0;