serial: qcom: use check for empty instead of pending
authorJiri Slaby <jslaby@suse.cz>
Thu, 21 Apr 2022 10:17:06 +0000 (12:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Apr 2022 14:21:53 +0000 (16:21 +0200)
The code wants to know if the circ buffer is empty, so use the proper
macro.

No functional change intended, just saner function name used for that
use case.

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220421101708.5640-6-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index 1543a6028856278132754437ce055216a6b9fb6b..f4961022d7d07ab34eef1160ca56f6af0a67860f 100644 (file)
@@ -507,7 +507,7 @@ static void qcom_geni_serial_console_write(struct console *co, const char *s,
                 */
                qcom_geni_serial_poll_tx_done(uport);
 
-               if (uart_circ_chars_pending(&uport->state->xmit)) {
+               if (!uart_circ_empty(&uport->state->xmit)) {
                        irq_en = readl(uport->membase + SE_GENI_M_IRQ_EN);
                        writel(irq_en | M_TX_FIFO_WATERMARK_EN,
                                        uport->membase + SE_GENI_M_IRQ_EN);