bus: ixp4xx: return on error in ixp4xx_exp_probe()

This code was intended to return an error code if regmap_read() fails
but the return statement was missing.

Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20210807230016.3607666-1-linus.walleij@linaro.org'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/bus/intel-ixp4xx-eb.c b/drivers/bus/intel-ixp4xx-eb.c
index 9acd00da413c2f24147e789d7b213544657b5a79..a4388440aca7a8def5f4aaa3ab0a3ddcff4ddcce 100644 (file)
--- a/drivers/bus/intel-ixp4xx-eb.c
+++ b/drivers/bus/intel-ixp4xx-eb.c
@@ -369,7 +369,7 @@ static int ixp4xx_exp_probe(struct platform_device *pdev)
        /* We check that the regmap work only on first read */
        ret = regmap_read(eb->rmap, IXP4XX_EXP_CNFG0, &val);
        if (ret)
-               dev_err_probe(dev, ret, "cannot read regmap\n");
+               return dev_err_probe(dev, ret, "cannot read regmap\n");
        if (val & IXP4XX_EXP_CNFG0_MEM_MAP)
                eb->bus_base = IXP4XX_EXP_BOOT_BASE;
        else