drm/amd/powerplay: remove the support of xgmi pstate on vega20 from swsmu
authorKevin Wang <kevin1.wang@amd.com>
Wed, 20 May 2020 03:25:23 +0000 (11:25 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 May 2020 18:00:49 +0000 (14:00 -0400)
the vega20 asic uses legacy powerplay driver by default.

1. cleanup is_support_sw_smu_xgmi() function.
(only use for vega20 xgmi pstate check)
2. by default, the vega20 set xgmi pstate by legacy powerplay routine.

Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h

index d2a105e3bf7cccd98e70681b31b32f028d0e9367..6a39996487b9c514871c93bd7f6f6152eeba42d2 100644 (file)
@@ -1162,7 +1162,7 @@ int amdgpu_dpm_set_xgmi_pstate(struct amdgpu_device *adev,
 {
        int ret = 0;
 
-       if (is_support_sw_smu_xgmi(adev))
+       if (is_support_sw_smu(adev))
                ret = smu_set_xgmi_pstate(&adev->smu, pstate);
        else if (adev->powerplay.pp_funcs &&
                 adev->powerplay.pp_funcs->set_xgmi_pstate)
@@ -1197,4 +1197,4 @@ int amdgpu_dpm_allow_xgmi_power_down(struct amdgpu_device *adev, bool en)
                return smu_allow_xgmi_power_down(smu, en);
 
        return 0;
-}
\ No newline at end of file
+}
index 8c684a6e0156547df01b48abfacffee58b76a503..975a4d5bc34bda50753d6ff369d5c754a7cb415a 100644 (file)
@@ -576,17 +576,6 @@ bool is_support_sw_smu(struct amdgpu_device *adev)
        return false;
 }
 
-bool is_support_sw_smu_xgmi(struct amdgpu_device *adev)
-{
-       if (!is_support_sw_smu(adev))
-               return false;
-
-       if (adev->asic_type == CHIP_VEGA20)
-               return true;
-
-       return false;
-}
-
 int smu_sys_get_pp_table(struct smu_context *smu, void **table)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
index 4d1c2a44a8b6e927ed1f5757e01acd52fb8c6947..bac7e13dc801ef4d31248118a3ae0da11e3cdb53 100644 (file)
@@ -675,7 +675,6 @@ int smu_update_table(struct smu_context *smu, enum smu_table_id table_index, int
                     void *table_data, bool drv2smu);
 
 bool is_support_sw_smu(struct amdgpu_device *adev);
-bool is_support_sw_smu_xgmi(struct amdgpu_device *adev);
 int smu_reset(struct smu_context *smu);
 int smu_common_read_sensor(struct smu_context *smu, enum amd_pp_sensors sensor,
                           void *data, uint32_t *size);