arm64: dts: cavium: Fix GICv3 ITS nodes
authorRob Herring <robh@kernel.org>
Wed, 8 Feb 2023 18:55:06 +0000 (12:55 -0600)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 17 Mar 2023 12:39:00 +0000 (13:39 +0100)
The GICv3 ITS is an MSI controller, therefore its node name should be
'msi-controller'. The ITS node is also expected to have '#msi-cells'.
Add it on Thunder as there are no users. Thunder2 uses 'msi-parent', but
Robin says that should be 'msi-map' instead and I'm not sure what's
correct for it.

The unit-addresses of both the ITS and main GIC node on thunder2 are also
wrong, so fix them while we're here.

Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230208185506.2305349-1-robh@kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi

index e0a71795261b826c5ffa5efb22df6736036ffe7a..8ad31dee11a3c10e20e8d32ad6530d2f56dda9c0 100644 (file)
                              <0x8010 0x80000000 0x0 0x600000>; /* GICR */
                        interrupts = <1 9 0xf04>;
 
-                       its: gic-its@8010,00020000 {
+                       its: msi-controller@801000020000 {
                                compatible = "arm,gic-v3-its";
                                msi-controller;
+                               #msi-cells = <1>;
                                reg = <0x8010 0x20000 0x0 0x200000>;
                        };
                };
index dfb41705a9a935b9df5353e9d485feff1ddda832..3419bd252696c41e63735a40107822f4517b1296 100644 (file)
@@ -55,7 +55,7 @@
                method = "smc";
        };
 
-       gic: interrupt-controller@400080000 {
+       gic: interrupt-controller@4000080000 {
                compatible = "arm,gic-v3";
                #interrupt-cells = <3>;
                #address-cells = <2>;
@@ -67,7 +67,7 @@
                      <0x04 0x01000000 0x0 0x1000000>;  /* GICR */
                interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
 
-               gicits: gic-its@40010000 {
+               gicits: msi-controller@4000100000 {
                        compatible = "arm,gic-v3-its";
                        msi-controller;
                        reg = <0x04 0x00100000 0x0 0x20000>;    /* GIC ITS */