regulator: virtual: warn against production use
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Tue, 1 Mar 2022 11:18:30 +0000 (12:18 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 2 Mar 2022 13:45:30 +0000 (13:45 +0000)
This driver is only meant for debugging and testing.  Currently, it's
not possible to use it without patching the kernel since it requires
platform data, but we'll be adding devicetree support, so add a loud
warning to make it clear that it's still only meant for debugging and
testing.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Link: https://lore.kernel.org/r/20220301111831.3742383-3-vincent.whitchurch@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/virtual.c

index 50d2e9caaa7192515d96662a926bcf14fff178ce..9e0abbee1df56dace0a5d9fa4abb3f3955dbd8a6 100644 (file)
@@ -285,8 +285,21 @@ static int regulator_virtual_probe(struct platform_device *pdev)
 {
        char *reg_id = dev_get_platdata(&pdev->dev);
        struct virtual_consumer_data *drvdata;
+       static bool warned;
        int ret;
 
+       if (!warned) {
+               warned = true;
+               pr_warn("**********************************************************\n");
+               pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
+               pr_warn("**                                                      **\n");
+               pr_warn("** regulator-virtual-consumer is only for testing and   **\n");
+               pr_warn("** debugging.  Do not use it in a production kernel.    **\n");
+               pr_warn("**                                                      **\n");
+               pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
+               pr_warn("**********************************************************\n");
+       }
+
        drvdata = devm_kzalloc(&pdev->dev, sizeof(struct virtual_consumer_data),
                               GFP_KERNEL);
        if (drvdata == NULL)