clk: intel: Avoid unnecessary memset by improving code
authorRahul Tanwar <rahul.tanwar@linux.intel.com>
Thu, 16 Jul 2020 06:30:32 +0000 (14:30 +0800)
committerStephen Boyd <sboyd@kernel.org>
Fri, 24 Jul 2020 08:58:15 +0000 (01:58 -0700)
memset can be avoided in a loop if the variables used are declared
inside the loop. Move such variables declaration inside the loop
to avoid memset.

Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Link: https://lore.kernel.org/r/26624b65d0e6b958c4765a406b9929d1a9ce1c2c.1594880946.git.rahul.tanwar@linux.intel.com
[sboyd@kernel.org: Drop NULL assignment that is overwritten]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/x86/clk-cgu.c

index c379fedfb9f23919e03b76de5c44390848b61559..33de600e0c38e4664a0fa667978284c1fee76d8e 100644 (file)
@@ -581,19 +581,18 @@ int lgm_clk_register_ddiv(struct lgm_clk_provider *ctx,
                          unsigned int nr_clk)
 {
        struct device *dev = ctx->dev;
-       struct clk_init_data init = {};
-       struct lgm_clk_ddiv *ddiv;
        struct clk_hw *hw;
        unsigned int idx;
        int ret;
 
        for (idx = 0; idx < nr_clk; idx++, list++) {
-               ddiv = NULL;
+               struct clk_init_data init = {};
+               struct lgm_clk_ddiv *ddiv;
+
                ddiv = devm_kzalloc(dev, sizeof(*ddiv), GFP_KERNEL);
                if (!ddiv)
                        return -ENOMEM;
 
-               memset(&init, 0, sizeof(init));
                init.name = list->name;
                init.ops = &lgm_clk_ddiv_ops;
                init.flags = list->flags;