drm/i915/huc: Stop printing about unsupported HuC on MTL
authorDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Thu, 9 Nov 2023 23:54:36 +0000 (15:54 -0800)
committerDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Thu, 16 Nov 2023 21:48:46 +0000 (13:48 -0800)
On MTL, the HuC is only supported on the media GT, so our validation
check on the module parameter detects an inconsistency on the root GT
(the modparams asks to enable HuC, but the support is not there) and
prints the following info message:

[drm] GT0: Incompatible option enable_guc=3 - HuC is not supported!

This can be confusing to the user and make them think that something is
wrong when it isn't, so we need to silence it.
Given that any platform that supports HuC also supports GuC, if a user
tries to enable HuC on a platform that really doesn't support it they'll
already see a message about GuC not being supported, so instead of just
silencing the HuC message on newer platforms we can just get rid of it
entirely.

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: John Harrison <john.c.harrison@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231109235436.2349963-1-daniele.ceraolospurio@intel.com
drivers/gpu/drm/i915/gt/uc/intel_uc.c

index 27f6561dd731908f1d1b36d7892dfceadcb951e0..3872d309ed31fa6a313bd7d0d72f3e5ccde679ec 100644 (file)
@@ -106,11 +106,6 @@ static void __confirm_options(struct intel_uc *uc)
                gt_info(gt,  "Incompatible option enable_guc=%d - %s\n",
                        i915->params.enable_guc, "GuC is not supported!");
 
-       if (i915->params.enable_guc & ENABLE_GUC_LOAD_HUC &&
-           !intel_uc_supports_huc(uc))
-               gt_info(gt, "Incompatible option enable_guc=%d - %s\n",
-                       i915->params.enable_guc, "HuC is not supported!");
-
        if (i915->params.enable_guc & ENABLE_GUC_SUBMISSION &&
            !intel_uc_supports_guc_submission(uc))
                gt_info(gt, "Incompatible option enable_guc=%d - %s\n",